support filesystems.Ignore on windows #303

Merged
merged 1 commit into from Jan 12, 2017

Projects

None yet

3 participants

@Songmu
Member
Songmu commented Jan 1, 2017

No description provided.

@Songmu Songmu support filesystem.IgnoreRegexp on windows
e8905fd
@Songmu Songmu changed the title from support filesystems.Ignore on windows to [wip] support filesystems.Ignore on windows Jan 4, 2017
@Songmu Songmu changed the title from [wip] support filesystems.Ignore on windows to support filesystems.Ignore on windows Jan 8, 2017
@astj

Reviewed!

}
// NewFilesystemGenerator XXX
-func NewFilesystemGenerator() (*FilesystemGenerator, error) {
- return &FilesystemGenerator{}, nil
+func NewFilesystemGenerator(ignoreReg *regexp.Regexp) (*FilesystemGenerator, error) {
@astj
astj Jan 10, 2017 edited Contributor

You need to pass ignoreReg on command/command_windows.go, like *nix oses (ref: https://github.com/mackerelio/mackerel-agent/blob/master/command/command_linux.go#L32 )

@astj
astj approved these changes Jan 11, 2017 View changes

LGTM

}
// NewFilesystemGenerator XXX
-func NewFilesystemGenerator() (*FilesystemGenerator, error) {
- return &FilesystemGenerator{}, nil
+func NewFilesystemGenerator(ignoreReg *regexp.Regexp) (*FilesystemGenerator, error) {
@syou6162 syou6162 merged commit 0496dd5 into master Jan 12, 2017

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 68.807%
Details
@syou6162 syou6162 deleted the support-ignore-regexp-on-win branch Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment