New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose http.Client to make the library work on GAE #53

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
3 participants
@aereal
Contributor

aereal commented Dec 9, 2017

On Google App Engine Go Standard Environment, we have to use urlfetch instead of net/http.

urlfetch.Client(ctx) returns a net/http.Client instance that can issue HTTP(S) request on GAE environment, and we should pass it to mackerel-client-go.

See also: https://cloud.google.com/appengine/docs/standard/go/issue-requests

(Yes, I understand that any changes should be with tests, but I have no good idea...)

@itchyny itchyny changed the title from Add support for GAE/Go to Expose http.Client to make the library work on GAE Dec 11, 2017

@itchyny

This comment has been minimized.

Show comment
Hide comment
@itchyny

itchyny Dec 11, 2017

Contributor

LGTM!

Contributor

itchyny commented Dec 11, 2017

LGTM!

@itchyny itchyny merged commit 984eab8 into mackerelio:master Dec 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 61.726%
Details
@astj

This comment has been minimized.

Show comment
Hide comment
@astj

astj Dec 11, 2017

Contributor

but I have no good idea..

Maybe you can test it by replacing http.Client to some dummy client

Contributor

astj commented Dec 11, 2017

but I have no good idea..

Maybe you can test it by replacing http.Client to some dummy client

@itchyny itchyny referenced this pull request Oct 16, 2018

Closed

Client.Request is racy #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment