Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use HTTP_PROXY when requesting API #28

Merged
merged 6 commits into from May 24, 2019

Conversation

Projects
None yet
2 participants
@hayajo
Copy link
Contributor

commented May 22, 2019

  • Local HTTP proxy environment affect the API request.
  • Fixed to not use HTTP proxy in API request.
@@ -115,8 +115,8 @@ func createHTTPClient(caCert []byte, insecureTLS bool) *http.Client {
DualStack: true,
}
// Copy from the definition of http.DefaultTransport.
// Don't use Proxy.

This comment has been minimized.

Copy link
@itchyny

itchyny May 23, 2019

Contributor

Why not Proxy: nil here, like the other places?

This comment has been minimized.

Copy link
@hayajo

hayajo May 23, 2019

Author Contributor

Since the zero value of the Transport.Proxy is nil, it does not explicitly set.

@hayajo

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

Thank you!

@hayajo hayajo merged commit e179a4e into master May 24, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@hayajo hayajo deleted the no-proxy-api-client branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.