New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update subcommand should keep the interface infromation #174

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
2 participants
@itchyny
Contributor

itchyny commented Oct 30, 2018

Updating the display name by mkr update --displayName foobar removes the interfaces information unexpectedly. This pull request fixes the params to keep the interfaces information. Other fields are not necessarily filled because they are not deleted when empty.

@itchyny itchyny changed the title from update subcommand should keep interfaces in the parameters to update subcommand should keep the interface infromation Oct 30, 2018

@astj

astj approved these changes Oct 30, 2018

@itchyny itchyny merged commit ad13446 into master Oct 30, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@itchyny itchyny deleted the fix-update-command-param branch Oct 30, 2018

@yuuki yuuki referenced this pull request Nov 12, 2018

Merged

Release version 0.33.0 #177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment