Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add out stream argument to format.PrettyPrintJSON #193

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@itchyny
Copy link
Contributor

itchyny commented Mar 8, 2019

This is the first step to improve test coverage.

Future plans:

  • Split each command to packages (like hostApp)
  • Each app has client interface so that we can mock in tests
  • Each app has outStream io.Writer so that we can test
  • Write much more and more tests!

I think we can start with hosts subcommand or org subcommand (which is very easy!).

@astj

astj approved these changes Mar 8, 2019

@itchyny

This comment has been minimized.

Copy link
Contributor Author

itchyny commented Mar 8, 2019

Thanks.

@itchyny itchyny merged commit 48ed634 into master Mar 8, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@itchyny itchyny deleted the pretty-print-arg branch Mar 8, 2019

@lufia lufia referenced this pull request Mar 27, 2019

Merged

Release version 0.36.0 #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.