Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Client interface for Mackerel API #194

Merged
merged 5 commits into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@itchyny
Copy link
Contributor

itchyny commented Mar 8, 2019

In order to write mock tests, I want to introduce interface for Mackerel API Client. This is much like https://github.com/mackerelio/mackerel-container-agent/blob/2d193452f862b96a61364e95e4dbf450bb6ac17e/api/client.go.

Future plans:

  • Split subcommands to packages (like hostsApp)
  • Add methods to the Client interface if required by the commands.
  • Add mock tests.
  • Remove mackerelclient.NewFromContext.

I want to change import alias mkr to mackerel, so that we can change the top directory of this repository to mkr package (move main.go to cmd/mkr/).

@itchyny itchyny force-pushed the client-interface branch 2 times, most recently from 605fa19 to 4690446 Mar 8, 2019

@itchyny itchyny force-pushed the client-interface branch from 4690446 to f088011 Mar 8, 2019

@astj

astj approved these changes Mar 11, 2019

@itchyny itchyny merged commit 7f18436 into master Mar 11, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@itchyny itchyny deleted the client-interface branch Mar 11, 2019

@lufia lufia referenced this pull request Mar 27, 2019

Merged

Release version 0.36.0 #202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.