Mackenzie maco

Organizations

@Growstuff
maco commented on pull request Growstuff/growstuff#742
@maco

After re-running it, it turned green. twilight zone music On Fri, May 22, 2015 at 10:20 AM Shiho Takagi notifications@github.com wrote: @maco http…

maco commented on pull request Growstuff/growstuff#742
@maco

Also I created the pr and it passed, then I noticed the pr was changing schema.rb (unintended) so I backed out the schema.rb change, and then it fa…

maco commented on pull request Growstuff/growstuff#736
@maco

A bunch of stuff was merged yesterday, and it looks like it's causing a conflict. Could you update your local branch and resolve the conflict?

maco opened pull request Growstuff/growstuff#742
@maco
Moving myself to the committers section
2 commits with 1 addition and 1 deletion
maco pushed to dev at maco/growstuff
@maco
  • @maco c5fbda0
    cleaning up inadvertent schema change
maco pushed to dev at maco/growstuff
@maco
maco opened pull request davedash/parental-leave#21
@maco
adding Cisco including new policy as of June 1, 2015
1 commit with 2 additions and 0 deletions
@maco
maco commented on pull request Growstuff/growstuff#731
@maco

As soon as release 8 is pushed live, I have about 10 things to merge right away.

maco commented on pull request Growstuff/growstuff#737
@maco

looks good to me. thanks!

maco commented on issue Growstuff/growstuff#649
@maco

does the date of closure on this suggest it was actually part of release 8?

maco commented on pull request Growstuff/growstuff#688
@maco

Because I have to be that person... do we know how this comes across for users of screen readers? Is the raw data spoken out loud? (ex: "sun thirty…

maco commented on pull request Growstuff/growstuff#727
@maco

looks good to me

maco commented on pull request Growstuff/growstuff#736
@maco

looks good to me

maco commented on pull request Growstuff/growstuff#735
@maco

What's going on with content_for :title is that its location is already set in https://github.com/Growstuff/growstuff/blob/dev/app/views/layouts/ap…

@maco
We should add the Bootstrap Accessibility plugin
maco commented on pull request Growstuff/growstuff#731
@maco

I find those browser windows annoying; therefore, I love you right now.

maco commented on pull request Growstuff/growstuff#730
@maco

I'm with @cesy

maco commented on pull request Growstuff/growstuff#700
@maco

Let's put this in release 9, because I have seed photos for release 9, and my branch for that depends on this one being merged first (because I'm n…

maco commented on pull request Growstuff/growstuff#732
maco opened pull request Growstuff/growstuff#732
@maco
PR for release 8
249 commits with 2,213 additions and 364 deletions
@maco
  • @maco bd0da36
    reverse the rejection_explanation logic to not use !=
@maco
  • @maco 6dedf1b
    add test for crop.rejection_explanation function
maco commented on pull request Growstuff/growstuff#726
@maco

Oh, I should add a test for the helper function.

@maco
  • @maco 920ca29
    add helper function for crop rejection explanation and use it on both…
maco opened pull request Growstuff/growstuff#726
@maco
Crop accept/reject notification improvements
1 commit with 9 additions and 5 deletions
@maco
  • @maco 9e53105
    make language for crop accept/reject friendlier and if reason for rej…
  • @maco 6505254
    Merge pull request #724 from tygriffin/pending-rejected-sci-alt-names
  • 3 more commits »
@maco
  • @maco 6505254
    Merge pull request #724 from tygriffin/pending-rejected-sci-alt-names
  • @tygriffin ead9a25
    test that status message appears when rejected / pending
  • 1 more commit »
maco merged pull request Growstuff/growstuff#724
@maco
Pending rejected sci alt names
2 commits with 37 additions and 12 deletions