Skip to content
Permalink
Browse files

mportexec: Remove misleading errorInfo output

The port target was evaluated in a separate Tcl slave interpreter, which
depending on the way it exits, does not necessarily update $::errorInfo
of the master interpreter. Therefore $::errorInfo in the master
interpreter often contains unrelated error information which leads to
confusion in the log file and caused tickets to be filed with the wrong
information.

All error information related to the failure should have already been
emitted by the slave interpreter.

Closes: https://trac.macports.org/ticket/55560
(cherry picked from commit 113ef21)
  • Loading branch information
raimue committed Mar 21, 2018
1 parent 4c1d778 commit 0ebdf20e8a82ae45422a9ed6bea106f9381992d5
Showing with 0 additions and 2 deletions.
  1. +0 −2 src/macports1.0/macports.tcl
@@ -2021,8 +2021,6 @@ proc _mportexec {target mport} {
macports::pop_log
return 0
} else {
# An error occurred.
ui_debug $::errorInfo
if {[info exists ::logenabled] && $::logenabled && [info exists ::debuglogname]} {
ui_error "See $::debuglogname for details."
}

0 comments on commit 0ebdf20

Please sign in to comment.
You can’t perform that action at this time.