Skip to content
Permalink
Browse files

Back out previous "fix" to option_proc - it only "worked" by masking …

…the symptoms entirely. I'll have to

do more checking into why the option gets occasionally set to "uplist" and blows up the trace function.

P.S. This code is very hard to understand.  I don't even know why it globalizes this variable, but it's
obviously essential to its function to do so.  Just reading the function itself is not enlightening at
all given that this code is essentially write-only.  Perhaps PERL should have been chosen as the implementation
language instead - at least then it would have been deliberate. :)

git-svn-id: https://svn.macports.org/repository/macports/trunk/base@4456 d073be05-634f-4543-b044-5fe20cf6d1d6
  • Loading branch information
Jordan K. Hubbard
Jordan K. Hubbard committed Jan 5, 2004
1 parent dd2e6ef commit d13a4fb27156cbba6f2c7ec064571cca85ace959
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/port1.0/portutil.tcl
@@ -167,7 +167,7 @@ proc option_deprecate {option {newoption ""} } {
}

proc option_proc {option args} {
global option_procs
global option_procs $option
eval "lappend option_procs($option) $args"
# Add a read trace to the variable, as the option procedures have no access to reads
trace variable $option rwu option_proc_trace

0 comments on commit d13a4fb

Please sign in to comment.
You can’t perform that action at this time.