Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd check that port can be used on current platform #68
Conversation
Implement a check that the current platform is in the port's platforms list. This only handles the current platforms statement in the Portfile. see https://trac.macports.org/ticket/15712
|
This is a WIP to see if this is how we want to do this. This can be committed as-is or we can wait until I figure out all the conditionals in the trac ticket. I'll also have to a lot of tests to verify it all works. A wrong platform will error out before the arch check. Note: the _mportexec check is for the dependencies install. |
|
Does this handle things like |
|
No, it doesn't. This should not be merged in its current form because it does not handle |
|
I don't think I understand exactly what needs done here so I'll close this for now. |
|
I think what was being asked for was the ability to specify conditionals describing which platforms and os versions to build or not to build on. We do desperately need a facility like this, though. |
|
I think if I were running on an unsupported (or marginally supported) platform, I'd be more interested in "did this work for other people" rather than "did the maintainer test it on my platform" (I don't exhaustively test on every platform, so I wouldn't be marking all of the 'it doesn't build here' possibilities, for example). If we collected and exposed metadata about build success/failures (from the build infrastructure and maybe also from volunteers) that port could query and use in display to users, I think that that would be more useful. |
|
The question isn't one of "did the maintainer test it". I have ports like OCaml that I know do not run on certain OSes but I get build errors for them anyway every time I touch them, which creates noise and confusion and wastes time on the build systems. The goal is to stop trying to build on things where we know building will not work and can never work. There are a lot of such things. |
|
Ok. Making life easier for maintainer / macports-build infrastructure related and not a feature for end-users. I think we just shouldn't bother building stuff for so many (old/non-supported/not being updated) OS releases. |
|
That's another argument to be had. For now, I'd like to mark that OCaml can't build on 10.4 and 10.5. |
kurthindenburg commentedMar 24, 2018
Implement a check that the current platform is in the port's
platforms list.
This only handles the current platforms statement in the Portfile.
see https://trac.macports.org/ticket/15712