Skip to content
Permalink
Browse files

curl-ca-bundle: Use shellescape

  • Loading branch information
ryandesign committed Jun 27, 2020
1 parent 6dd4916 commit 2cab39a38a8830c859eb7ef89d1edb9ae4313e6d
Showing with 1 addition and 1 deletion.
  1. +1 −1 net/curl/Portfile
@@ -259,7 +259,7 @@ subport curl-ca-bundle {
${worksrcdir}/lib/mk-ca-bundle.pl

post-extract {
system -W ${workpath} "unzip -q -a '${distpath}/${certdata_distfile}'"
system -W ${workpath} "unzip -q -a [shellescape ${distpath}/${certdata_distfile}]"
move ${workpath}/mozilla-central-${certdata_commit}/${certdata_path} ${worksrcpath}/${certdata_file}
}

4 comments on commit 2cab39a

@blair

This comment has been minimized.

Copy link
Contributor

@blair blair replied Jun 27, 2020

This change appears to break on High Sierra:

# port -v upgrade --enforce-variants outdated          --->  Computing dependencies for curl-ca-bundle.
--->  Fetching distfiles for curl-ca-bundle
--->  curl-7.71.0.tar.xz does not exist in /opt/local/var/macports/distfiles/curl
--->  Attempting to fetch curl-7.71.0.tar.xz from https://distfiles.macports.org/curl
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 2323k  100 2323k    0     0  5626k      0 --:--:-- --:--:-- --:--:-- 5625k
--->  certdata-20200617-712412cb974c0392afe31fd9ce974b26ae3993c3.zip does not exist in /opt/local/var/macports/distfiles/curl
--->  Attempting to fetch certdata-20200617-712412cb974c0392afe31fd9ce974b26ae3993c3.zip from https://distfiles.macports.org/curl
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  247k  100  247k    0     0  7221k      0 --:--:-- --:--:-- --:--:-- 7286k
--->  Verifying checksums for curl-ca-bundle
--->  Checksumming curl-7.71.0.tar.xz
--->  Checksumming certdata-20200617-712412cb974c0392afe31fd9ce974b26ae3993c3.zip
--->  Extracting curl-ca-bundle
--->  Extracting curl-7.71.0.tar.xz
Executing:  cd "/opt/local/var/macports/build/_Users_blair_Code_MacPorts_macports-ports.git_net_curl/curl-ca-bundle/work" && /opt/local/bin/xz -dc '/opt/local/var/macports/distfiles/curl/curl-7.71.0.tar.xz' | /usr/bin/tar -xf - curl-7.71.0/Makefile curl-7.71.0/lib/mk-ca-bundle.pl
Error: Failed to extract curl-ca-bundle: invalid command name "shellescape"
Error: See /opt/local/var/macports/logs/_Users_blair_Code_MacPorts_macports-ports.git_net_curl/curl-ca-bundle/main.log for details.
@hapaguy

This comment has been minimized.

Copy link

@hapaguy hapaguy replied Jun 27, 2020

Also on Catalina. Is there some missing dependency?

@jmroot

This comment has been minimized.

Copy link
Member

@jmroot jmroot replied Jun 28, 2020

This feature is not in a release yet.

@ryandesign

This comment has been minimized.

Copy link
Contributor Author

@ryandesign ryandesign replied Jun 28, 2020

Whoops, sorry. Fixed in 6c5276d.

Please sign in to comment.
You can’t perform that action at this time.