Skip to content
Permalink
Browse files

ipmitool: Blacklist clang < 500

  • Loading branch information
ryandesign committed Jun 26, 2020
1 parent 8372dcf commit 766e92fdb2668fa4c2f54c02f1bcf6dbe6a8724d
Showing with 4 additions and 1 deletion.
  1. +4 −1 sysutils/ipmitool/Portfile
@@ -1,6 +1,7 @@
# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4

PortSystem 1.0
PortGroup compiler_blacklist_versions 1.0
PortGroup github 1.0
PortGroup legacysupport 1.1

@@ -48,8 +49,10 @@ checksums \
configure.args --enable-intf-lanplus --enable-ipmishell
configure.cppflags-append -Ds6_addr16=__u6_addr.__u6_addr16

# https://trac.macports.org/ticket/59066
compiler.c_standard 2011
# Work around MacPorts base C11 compiler selection bug.
# https://github.com/macports/macports-base/pull/196
compiler.blacklist-append {clang < 500}

pre-configure {
system -W ${worksrcpath} "./bootstrap"

4 comments on commit 766e92f

@kencu

This comment has been minimized.

Copy link
Contributor

@kencu kencu replied Jun 26, 2020

we really need to find a way to move portconfigure.tcl logic into the ports tree somehow so we can hotfix these issues rather than having to work around them in dozens of ports until the next base release.

@ryandesign

This comment has been minimized.

Copy link
Contributor Author

@ryandesign ryandesign replied Jun 26, 2020

If you think so, make a ticket for it. But these kinds of bugs shouldn't happen that often.

@kencu

This comment has been minimized.

Copy link
Contributor

@kencu kencu replied Jun 26, 2020

They shouldn't but we have the thread_local workaround going, and the c++17 workaround, and I think there's a c++14 workaround floating around too.

And there will be more-than-likely lots of tweaking with the new universal issues that are sure to be coming right around the corner.

I wonder how much uproar it would cause to find a way to move it in...

@kencu

This comment has been minimized.

Copy link
Contributor

@kencu kencu replied Jun 26, 2020

Please sign in to comment.
You can’t perform that action at this time.