Skip to content
Permalink
Browse files

net/wireshark3: undo non-maintainer changes and replace with work mai…

…ntainer had in progress.
  • Loading branch information
ghosthound committed Apr 25, 2019
1 parent 885e967 commit c12589f56fac0bba08baed18577588f7046b294b
Showing with 15 additions and 12 deletions.
  1. +15 −12 net/wireshark3/Portfile
@@ -61,7 +61,21 @@ configure.args-append \
-DENABLE_ZLIB=OFF \
-DBUILD_wireshark=OFF

variant qt5 conflicts no_gui description {Build wireshark with a qt5 GUI} { }
variant qt5 conflicts no_gui description {Build wireshark with a qt5 GUI} {
PortGroup qt5 1.0
configure.args-replace -DENABLE_APPLICATION_BUNDLE=OFF -DENABLE_APPLICATION_BUNDLE=ON
configure.args-replace -DBUILD_wireshark=OFF -DBUILD_wireshark=ON
configure.args-append -DENABLE_QT5=ON
qt5.depends_component qtbase \
qtmacextras \
qtmultimedia \
qtsvg \
qttranslations

post-destroot {
move ${destroot}/${prefix}/bin/Wireshark.app ${destroot}${applications_dir}/Wireshark.app
}
}

variant no_gui conflicts qt5 description {do not build the wireshark GUI} {
## initial settings (above) handle this
@@ -135,17 +149,6 @@ if {![variant_isset qt5] && ![variant_isset no_gui]} {
default_variants-append +qt5
}

if {[variant_isset qt5]} {
PortGroup qt5 1.0
qt5.depends_component qtmacextras qtmultimedia qtsvg qttranslations
configure.args-replace -DENABLE_APPLICATION_BUNDLE=OFF -DENABLE_APPLICATION_BUNDLE=ON
configure.args-replace -DBUILD_wireshark=OFF -DBUILD_wireshark=ON
configure.args-append -DENABLE_QT5=ON
post-destroot {
move ${destroot}/${prefix}/bin/Wireshark.app ${destroot}${applications_dir}/Wireshark.app
}
}

## if no python3* variant is specified, add +python37
## XYZZY: it would be better to detect which python3* is already installed and use that...
if {![variant_isset python34] && ![variant_isset python35] && \

1 comment on commit c12589f

@cjones051073

This comment has been minimized.

Copy link
Contributor

@cjones051073 cjones051073 commented on c12589f Apr 27, 2019

Please note there was a reason I did things the way I did with the variant_isset method. If I did things your way some of the dependencies for other variants went missing, due to the fact when the qt5 port group is applied some of the deps from other variants get removed. Compare what you get from port deps wireshark3 for both methods.

Please sign in to comment.
You can’t perform that action at this time.