Skip to content
Permalink
Browse files

rtaudio: use_autoreconf

- use_autoreconf instead of the command
  • Loading branch information
ra1nb0w authored and michaelld committed Apr 9, 2019
1 parent f6e9b27 commit c88a970fb47cda7f44db236af0e4bb8df2f8e40a
Showing with 3 additions and 6 deletions.
  1. +3 −6 audio/rtaudio/Portfile
@@ -24,13 +24,10 @@ checksums rmd160 a9f5f7e602f9c7de6fa94e164706df32d33905ab \
revision 0

depends_build-append \
port:pkgconfig \
port:autoconf \
port:automake \
port:libtool
port:pkgconfig

# new versions will use cmake
configure.cmd ./autogen.sh
# future versions will use cmake
use_autoreconf yes
configure.args --with-core

build.args-append \

5 comments on commit c88a970

@ryandesign

This comment has been minimized.

Copy link
Contributor

@ryandesign ryandesign replied Apr 10, 2019

Since the project will switch to cmake soon it's moot here, but why make this change? If a project has gone to the trouble of providing a working autogen.sh script, we usually want to use it.

@michaelld

This comment has been minimized.

Copy link
Contributor

@michaelld michaelld replied Apr 10, 2019

Hmmm ... good points there Ryan. @ra1nb0w do you know if 'rtaudio' supports CMake builds yet? If so, can you figure out how to implement that instead? Using CMake is preferable to GNU Autotools IMHO. Otherwise I'd say let's just let this go & remember it for the future.

@ra1nb0w

This comment has been minimized.

Copy link
Contributor Author

@ra1nb0w ra1nb0w replied Apr 10, 2019

version 5.0.0 (last version available) has CMakeLists.txt but doesn't work. I started the port preferring cmake but it requires many changes/patches and at the end I choose to use autotools that works. The trunk works perfectly with cmake, and in fact implements some change that I did plus a refactor. The note is to remember that the new version can be migrated to cmake.

@michaelld

This comment has been minimized.

Copy link
Contributor

@michaelld michaelld replied Apr 10, 2019

Ok makes sense. I sounds like when the next version is released the CMake scripts might work better & so it's worth a try moving there at that time & thus then getting rid of all the autotools stuff. It's your port, so you can have that fun!

@ra1nb0w

This comment has been minimized.

Copy link
Contributor Author

@ra1nb0w ra1nb0w replied Apr 10, 2019

;-)

Please sign in to comment.
You can’t perform that action at this time.