Skip to content
Permalink
Browse files

gpredict: properly configure perl for intltool

Also remove dependency on p5.28-xml-parser since intltool
takes care of these perl dependencies for you.

This is probably overkill but at least it allows configure to report
the right perl (${prefix}/bin/perl5.28 instead of /usr/bin/perl).

No need for a rev-bump since there are no changes in the installed files.
  • Loading branch information
dbevans committed Apr 22, 2019
1 parent aab5e10 commit c9db61c0a8016ce8b8d2dd26ed11a745c92d30f6
Showing with 3 additions and 1 deletion.
  1. +3 −1 science/gpredict/Portfile
@@ -33,9 +33,11 @@ use_bzip2 yes
perl5.branches 5.28

depends_build port:intltool \
port:p${perl5.major}-xml-parser \
port:pkgconfig
depends_lib port:goocanvas2 \
port:curl

configure.env-append \
INTLTOOL_PERL=${perl5.bin}

livecheck.regex ${name}-(\[0-9.\]+)${extract.suffix}

1 comment on commit c9db61c

@jmroot

This comment has been minimized.

Copy link
Member

@jmroot jmroot commented on c9db61c Apr 23, 2019

This works until next time the version of perl used by intltool changes. The proper long-term fix is to remove the INTLTOOL_PERL check from configure altogether. (This is already done in the intltool.m4 from our intltool port, but upstream has not accepted or even acknowledged the patch we submitted years ago, so virtually all configure scripts generated by upstream projects remain affected.)

Please sign in to comment.
You can’t perform that action at this time.