Permalink
Browse files

clang/llvm-7.0: blacklist current compiler

the current compiler is always meant to be blacklisted if not installed
  • Loading branch information...
kencu committed Feb 11, 2019
1 parent 0d43191 commit e4b5bc78c3859b899689f16fae4951323247e8d8
Showing with 1 addition and 1 deletion.
  1. +1 −1 lang/llvm-7.0/Portfile
@@ -324,7 +324,7 @@ if {${subport} eq "lldb-${llvm_version}"} {

# blacklist current and future versions if they're not available in order to
# help break potential dependency cycles.
foreach ver {devel} {
foreach ver {7.0 devel} {
if {![file exists ${prefix}/bin/clang-mp-${ver}]} {
compiler.blacklist-append macports-clang-${ver}
}

3 comments on commit e4b5bc7

@cjones051073

This comment has been minimized.

Copy link
Contributor

cjones051073 replied Feb 11, 2019

This change whilst needed is clearly not future proof. What happens when clang 8, or 9, or... comes out. Does this list, and all the others in the other clang ports need updating again ?

Surely there is a better way to handle this... ?

@kencu

This comment has been minimized.

Copy link
Contributor Author

kencu replied Feb 12, 2019

So far, it's been manual -- I think this is the first time we've hiccupped. With each new clang version, there needs to be an addition to the list on every clang port. It was just missed last time, for the first time we can recall.

Open to thoughts if you have a better idea ! This is just Jeremy's method, extrapolated, so far.

@cjones051073

This comment has been minimized.

Copy link
Contributor

cjones051073 replied Feb 12, 2019

I guess my first question woukd be why the need to black list newer versions only if they are aren't already installed ? If instead they could always be blacklisted, then it would be possible to do it with a version check, hence explicitly state ‘everything newer than X’.

Please sign in to comment.