New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeRDP: Update to 2.0.0-rc1 #1317

Merged
merged 1 commit into from Feb 21, 2018

Conversation

4 participants
@metalefty
Contributor

metalefty commented Feb 16, 2018

Description

Most of the local patches are no longer needed since upstream improved macOS compatibility.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.13.3 17D47
Xcode 8.3 8E162

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

I overlooked this:

Please don't open a new Trac ticket if you are submitting a pull request.

so I created a new Trac ticket, sorry.

https://trac.macports.org/ticket/55829

@mf2k

This comment has been minimized.

Contributor

mf2k commented Feb 16, 2018

Can you please explain, and in the commit message, why you are removing the pulseaudio variant?

@metalefty

This comment has been minimized.

Contributor

metalefty commented Feb 17, 2018

Because FreeRDP on Mac no longer require PulseAudio to plackback remote audio locally. AFAIK PulseAudio is required only for that purpose in FreeRDP 1.1.0 port.

I'll add the explanation in commit message later.

@metalefty

This comment has been minimized.

Contributor

metalefty commented Feb 17, 2018

@mf2k I've updated the commit message.

@@ -4,13 +4,8 @@ PortSystem 1.0
PortGroup github 1.0
PortGroup cmake 1.0
epoch 2

This comment has been minimized.

@pmetzger

pmetzger Feb 18, 2018

Member

Removing the epoch is probably a bad idea. I would restore that.

This comment has been minimized.

@metalefty

metalefty Feb 19, 2018

Contributor

Sorry, I unintendedly removed it. Should I restore it by my self?

This comment has been minimized.

@pmetzger

pmetzger Feb 19, 2018

Member

Yah. Please carefully check all your changes, fix it, and push a new version. (Squash all the commits in the new version, we prefer to pull a single commit onto the tree.)

FreeRDP: Update to 2.0.0-rc1
Most of local patches no longer needed since upstream improved macOS
compatibility.  In particular, now FreeRDP support Mac native audio
(WITH_MACAUDIO) and it is enabled by default. PulseAudio variant is
removed from this port since it is replaced with native audio.

Closes: https://trac.macports.org/ticket/55829

@pmetzger pmetzger merged commit 5fe60a7 into macports:master Feb 21, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@pmetzger

This comment has been minimized.

Member

pmetzger commented Feb 21, 2018

Travis timed out, but this looks good. Merged. Thank you for your contribution to MacPorts!

@metalefty metalefty deleted the metalefty:freerdp-2.0.0 branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment