Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nagios ports: use https urls #3545

Merged
merged 1 commit into from Feb 2, 2019
Merged

Conversation

chrstphrchvz
Copy link
Contributor

@chrstphrchvz chrstphrchvz commented Feb 1, 2019

Description

Verification

Have you

@macportsbot
Copy link

macportsbot commented Feb 1, 2019

Travis Build #5106 Failed.

Lint results
--->  Verifying Portfile for nagios-plugins
Warning: Variant mysql56 does not have a description
Warning: Variant mysql57 does not have a description
Warning: Variant qstat does not have a description
--->  0 errors and 3 warnings found.
--->  Verifying Portfile for nagios
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for nrpe
Warning: Line 35 calling adduser directly; consider setting add_users instead
Warning: no license set
--->  0 errors and 2 warnings found.
--->  Verifying Portfile for nsca
Warning: Line 34 calling adduser directly; consider setting add_users instead
Warning: no license set
--->  0 errors and 2 warnings found.

Port nagios-plugins success on xcode9.4. Log
Port nagios success on xcode9.4. Log
Port nrpe fail on xcode9.4. Log
Port nsca success on xcode9.4. Log
Port nagios-plugins success on xcode8.3. Log
Port nagios success on xcode8.3. Log
Port nrpe fail on xcode8.3. Log
Port nsca success on xcode8.3. Log
Port nagios-plugins success on xcode7.3. Log
Port nagios success on xcode7.3. Log
Port nrpe fail on xcode7.3. Log
Port nsca success on xcode7.3. Log
Port nagios-plugins success on xcode10.1. Log
Port nagios success on xcode10.1. Log
Port nrpe fail on xcode10.1. Log

@yan12125
Copy link
Contributor

yan12125 commented Feb 1, 2019

There's an error while installing nrpe:

checking for SSL headers... configure: error: Cannot find ssl headers

(From https://paste.macports.org/0a94acbe96d4)

@chrstphrchvz Could you have a look?

@chrstphrchvz
Copy link
Contributor Author

chrstphrchvz commented Feb 1, 2019

@yan12125 I hadn't tried building these ports, but since all I changed in nrpe was the homepage, which isn't reused anywhere, that issue is likely present in the existing port.

The nrpe and nsca ports are very outdated (the versions in MacPorts are ~11 years old, but each has been updated within the past 3-6 years); I am not a user of them nor interesting in maintaining them. I'm inclined to submit another PR to see whether those two ports can be removed or if they should be updated.

@yan12125
Copy link
Contributor

yan12125 commented Feb 1, 2019

Sounds reasonable to drop both nsca and nrpe. There are no Trac traffic for them since 4 years ago, either.

@pmetzger
Copy link
Member

pmetzger commented Feb 1, 2019

@yan12125 Please shepherd this.

@yan12125
Copy link
Contributor

yan12125 commented Feb 1, 2019

Sure! @chrstphrchvz please open another PR to remove both ports.

@chrstphrchvz
Copy link
Contributor Author

chrstphrchvz commented Feb 2, 2019

I have dropped the changes to nrpe and nsca from this PR. I will open a PR to remove those ports shortly.

Update: see #3556

@macportsbot
Copy link

macportsbot commented Feb 2, 2019

Travis Build #5120 Passed.

Lint results
--->  Verifying Portfile for nagios-plugins
Warning: Variant mysql56 does not have a description
Warning: Variant mysql57 does not have a description
Warning: Variant qstat does not have a description
--->  0 errors and 3 warnings found.
--->  Verifying Portfile for nagios
--->  0 errors and 0 warnings found.

Port nagios-plugins success on xcode9.4. Log
Port nagios success on xcode9.4. Log
Port nagios-plugins success on xcode8.3. Log
Port nagios success on xcode8.3. Log
Port nagios-plugins success on xcode7.3. Log
Port nagios success on xcode7.3. Log
Port nagios-plugins success on xcode10.1. Log

@yan12125 yan12125 merged commit e23cc1c into macports:master Feb 2, 2019
@chrstphrchvz chrstphrchvz deleted the nagios-https branch Feb 2, 2019
@chrstphrchvz chrstphrchvz mentioned this pull request Mar 9, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants