Skip to content

mpstats: add subport mpstats-gsoc and stop submission of inactive ports #4521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2019
Merged

mpstats: add subport mpstats-gsoc and stop submission of inactive ports #4521

merged 1 commit into from
Jun 7, 2019

Conversation

arjunsalyan
Copy link
Member

Description

Submission of inactive ports is purposeless and only increases the size of data submitted- it can be removed.

mpstats-gsoc shall temporarily make submissions to https://frozen-falls-98471.herokuapp.com which is required to collect some initial data for development of macports-webapp.

Tested on

macOS 10.14
Xcode 10.1

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@neverpanic for port mpstats.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port labels Jun 3, 2019
@mojca
Copy link
Member

mojca commented Jun 3, 2019

You probably need to increase the revision (or version) after changing the behaviour (i.e. submission of inactive ports).

@macportsbot
Copy link

Travis Build #6732 Passed.

Lint results
--->  Verifying Portfile for mpstats
--->  0 errors and 0 warnings found.

Port mpstats success on xcode10.2. Log
Port mpstats-gsoc success on xcode10.2. Log
Port mpstats success on xcode9.4. Log
Port mpstats-gsoc success on xcode9.4. Log
Port mpstats success on xcode8.3. Log
Port mpstats-gsoc success on xcode8.3. Log
Port mpstats success on xcode7.3. Log
Port mpstats-gsoc success on xcode7.3. Log

@arjunsalyan
Copy link
Member Author

You probably need to increase the revision (or version) after changing the behaviour (i.e. submission of inactive ports).

Thanks, I have made revision 1.

@macportsbot
Copy link

Travis Build #6733 Passed.

Lint results
--->  Verifying Portfile for mpstats
--->  0 errors and 0 warnings found.

Port mpstats success on xcode10.2. Log
Port mpstats-gsoc success on xcode10.2. Log
Port mpstats success on xcode9.4. Log
Port mpstats-gsoc success on xcode9.4. Log
Port mpstats success on xcode8.3. Log
Port mpstats-gsoc success on xcode8.3. Log
Port mpstats success on xcode7.3. Log
Port mpstats-gsoc success on xcode7.3. Log

Copy link
Member

@mojca mojca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This almost looks well, except that

/opt/local/etc/LaunchDaemons/org.macports.mpstats-gsoc/org.macports.mpstats-gsoc.plist.default

seems to be referencing

/opt/local/libexec/mpstats

You probably need another reinplace inside files/mpstats.plist.default.

@mojca
Copy link
Member

mojca commented Jun 3, 2019

@neverpanic: since you are maintaining the ports, but weren't part of the discussion when we assigned the task to @arjunsalyan: this additional subport is meant for temporary statistics submission to the new site, so that we get sufficient statistics early enough to be able to work on nice presentation later in the summer. Once the site is ready to a sufficient degree and migrated under the macports domain, we would of course remove the subport and only submit to the new site.

This implementation allows submitting to both sites during the summer. While we could probably avoid multiple copies of the script, I didn't find it worth doing any changes at this point, and we can still make various improvements later in the summer.

@arjunsalyan: I can confirm that this works after doing that slight modification to the script. Thanks!

@macportsbot
Copy link

Travis Build #6738 Passed.

Lint results
--->  Verifying Portfile for mpstats
--->  0 errors and 0 warnings found.

Port mpstats success on xcode10.2. Log
Port mpstats-gsoc success on xcode10.2. Log
Port mpstats success on xcode9.4. Log
Port mpstats-gsoc success on xcode9.4. Log
Port mpstats success on xcode8.3. Log
Port mpstats-gsoc success on xcode8.3. Log
Port mpstats success on xcode7.3. Log

@arjunsalyan
Copy link
Member Author

You probably need another reinplace inside files/mpstats.plist.default.

Thanks, done.

@arjunsalyan arjunsalyan requested a review from mojca June 4, 2019 10:19
@mojca mojca merged commit 065547b into macports:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port
Development

Successfully merging this pull request may close these issues.

4 participants