mpstats: add subport mpstats-gsoc and stop submission of inactive ports#4521
Conversation
|
Notifying maintainers: |
|
You probably need to increase the revision (or version) after changing the behaviour (i.e. submission of inactive ports). |
|
Travis Build #6732 Passed. Lint resultsPort mpstats success on xcode10.2. Log |
Thanks, I have made |
|
Travis Build #6733 Passed. Lint resultsPort mpstats success on xcode10.2. Log |
mojca
left a comment
There was a problem hiding this comment.
This almost looks well, except that
/opt/local/etc/LaunchDaemons/org.macports.mpstats-gsoc/org.macports.mpstats-gsoc.plist.default
seems to be referencing
/opt/local/libexec/mpstats
You probably need another reinplace inside files/mpstats.plist.default.
|
@neverpanic: since you are maintaining the ports, but weren't part of the discussion when we assigned the task to @arjunsalyan: this additional subport is meant for temporary statistics submission to the new site, so that we get sufficient statistics early enough to be able to work on nice presentation later in the summer. Once the site is ready to a sufficient degree and migrated under the macports domain, we would of course remove the subport and only submit to the new site. This implementation allows submitting to both sites during the summer. While we could probably avoid multiple copies of the script, I didn't find it worth doing any changes at this point, and we can still make various improvements later in the summer. @arjunsalyan: I can confirm that this works after doing that slight modification to the script. Thanks! |
|
Travis Build #6738 Passed. Lint resultsPort mpstats success on xcode10.2. Log |
Thanks, done. |
Description
Submission of inactive ports is purposeless and only increases the size of data submitted- it can be removed.
mpstats-gsoc shall temporarily make submissions to https://frozen-falls-98471.herokuapp.com which is required to collect some initial data for development of macports-webapp.
Tested on
macOS 10.14
Xcode 10.1
Verification
Have you
port lint?sudo port test?sudo port -vst install?