Features/discourage base miners #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-ferreira
approved these changes
May 29, 2024
dbobrenko
approved these changes
May 31, 2024
Collaborator
dbobrenko
left a comment
dbobrenko
left a comment
There was a problem hiding this comment.
LGTM.
Should we specify the recommended model for miners in README?
Collaborator
Author
|
I don't think so, since mining with any of these base miners is essentially a trap, it probably is best that we don't outline any suggestions of which models to run. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small PR to explicitely discourage the use of baseminers on main.