Skip to content

Remove Reliance on Wikipedia Sections #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 25, 2024
Merged

Remove Reliance on Wikipedia Sections #306

merged 24 commits into from
Jul 25, 2024

Conversation

@bkb2135
Copy link
Collaborator

@bkb2135 bkb2135 commented Jul 23, 2024

No description provided.

bkb2135 and others added 4 commits July 16, 2024 16:48
@bkb2135
v2.5.2 (#287)
00d67a4 
* Point to macrocosmos entity

* Adjust project name

* Increase spec version to 2.5.2
@bkb2135
Storage Commit
3693088
@bkb2135
Use paragraphs instead of sections
42c073b
@bkb2135
Summarize whole context
b4422dd
@bkb2135 bkb2135 mentioned this pull request Jul 23, 2024
Closed
Hollyqui
Hollyqui previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@Hollyqui Hollyqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, check comments

dbobrenko
dbobrenko previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@dbobrenko dbobrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments

@bkb2135 bkb2135 changed the base branch from pre-staging to main July 24, 2024 13:12
@bkb2135 bkb2135 changed the base branch from main to pre-staging July 24, 2024 13:12
@bkb2135 bkb2135 dismissed stale reviews from dbobrenko and Hollyqui July 24, 2024 13:12

The base branch was changed.

dbobrenko
dbobrenko approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@dbobrenko dbobrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few cosmetic comments that you can ignore for now.

bkb2135 and others added 3 commits July 25, 2024 03:11
@bkb2135 @dbobrenko
Update prompting/tools/datasets/wiki.py
5569802 
Co-authored-by: Dmytro Bobrenko <17252809+dbobrenko@users.noreply.github.com>
@bkb2135 @dbobrenko
Update prompting/tools/datasets/wiki.py
0d1345d 
Co-authored-by: Dmytro Bobrenko <17252809+dbobrenko@users.noreply.github.com>
@bkb2135 @dbobrenko
Update prompting/tools/datasets/wiki.py
9de8985 
Co-authored-by: Dmytro Bobrenko <17252809+dbobrenko@users.noreply.github.com>
@bkb2135 bkb2135 changed the base branch from pre-staging to staging July 25, 2024 13:12
dbobrenko
dbobrenko reviewed Jul 25, 2024
View reviewed changes
@bkb2135 @dbobrenko
Update tests/fixtures/dataset.py
faeebaa 
Co-authored-by: Dmytro Bobrenko <17252809+dbobrenko@users.noreply.github.com>
dbobrenko
dbobrenko reviewed Jul 25, 2024
View reviewed changes
@dbobrenko dbobrenko merged commit b643f10 into staging Jul 25, 2024
@dbobrenko dbobrenko deleted the SN1-139-Wikipedia-Api-No-Longer-Returns-Sections branch July 25, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbobrenko dbobrenko dbobrenko approved these changes

@Hollyqui Hollyqui Hollyqui left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bkb2135 @dbobrenko @Hollyqui