Skip to content

Fix wikipedia summary and date #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Fix wikipedia summary and date #325

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b10b2a7
v2.6.0 (#309)
dbobrenko Jul 29, 2024
d77a632
Update wiki.py
bkb2135 Aug 4, 2024
6ba052a
Merging staging
bkb2135 Aug 5, 2024
2bec920
Split up content checks
bkb2135 Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions prompting/tools/datasets/wiki.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ def random(self, pages=10, seed=None, selector: Selector = None, **kwargs) -> Di
if seed is None
else _get_random_titles(pages=pages, seed=seed)
)
title = selector(titles)
title = random.choice(titles)
return self.get(title, selector=selector)


Expand Down Expand Up @@ -316,14 +316,20 @@ def _random_date(self) -> str:
date_sentence = self.extract_dates_and_sentences(context['content'])
context['content'] = date_sentence[1]
context['extra']['date'] = date_sentence[0]
if context['content'] is None:
if not context['content']:
continue
elif not context['extra']['date']:
continue
else:
return context

except Empty:
bt.logging.debug("Cache is empty. Skipping date until cache is filled.")
return None

except Exception as e:
bt.logging.error(f"Error fetching date: {e}")
continue

def get(
self,
Expand Down