New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: custom icons #100

Closed
chdiza opened this Issue Oct 24, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@chdiza
Contributor

chdiza commented Oct 24, 2015

@douglasdrumond @splhack @jpetrie It seems to me that we no longer generate those custom icons, at least not unless the user takes a special step. And when I do manually take that special step, nothing happens except make:MacVim-generic.icns' is up to date.. The manyicns` files are already built and there.

I want to simplify the Macvim Homebrew formula to remove its custom-icon code, so I'm just checking here that we in fact don't build custom icons anymore.

I think it's good that the icons are prebuilt, and we should think about removing the icon-generation stuff from our main repo. We have a github org now, so we can make a separate, icon-related repo under our umbrella to preserve the icon-generating scripts for posterity.

@jpetrie

This comment has been minimized.

Show comment
Hide comment
@jpetrie

jpetrie Oct 24, 2015

Member

Is this related to #99? I don't think I even realized there was icon generation going on, I thought we always had all of them pre-generated and checked in.

If the scripts in question are just for taking a big source icon and generating all the smaller permutations, and there's no existing common tool for doing so or something built-in to the Xcode tools suite, then moving it to it's own repository under macvim-dev so we can use it the next time the OS X icon style changes seems reasonable to me.

I guess this means MacVim will always have the new-style icon even on old OS X versions for which the style doesn't match? I don't know how much that matters; I certainly don't care as I don't use anything but the most-current OS X version. Do others?

That's my take on it.

Member

jpetrie commented Oct 24, 2015

Is this related to #99? I don't think I even realized there was icon generation going on, I thought we always had all of them pre-generated and checked in.

If the scripts in question are just for taking a big source icon and generating all the smaller permutations, and there's no existing common tool for doing so or something built-in to the Xcode tools suite, then moving it to it's own repository under macvim-dev so we can use it the next time the OS X icon style changes seems reasonable to me.

I guess this means MacVim will always have the new-style icon even on old OS X versions for which the style doesn't match? I don't know how much that matters; I certainly don't care as I don't use anything but the most-current OS X version. Do others?

That's my take on it.

@chdiza

This comment has been minimized.

Show comment
Hide comment
@chdiza

chdiza Oct 24, 2015

Contributor

No, it's not related to #99. That is, nothing regarding our generation scripts is responsible for the problem in #99. The problem there is about the app icon, not the document icons. It's only the latter that used to be script-generated on every build. If we can "fix" the app icon, #99 is done.

Contributor

chdiza commented Oct 24, 2015

No, it's not related to #99. That is, nothing regarding our generation scripts is responsible for the problem in #99. The problem there is about the app icon, not the document icons. It's only the latter that used to be script-generated on every build. If we can "fix" the app icon, #99 is done.

@chdiza

This comment has been minimized.

Show comment
Hide comment
@chdiza

chdiza Oct 24, 2015

Contributor

The icon-generating scripts are mainly for putting filetype-extension text on the document icons. There is no reason to do this on every build, which is why I'm glad it hasn't been happening on every build. I can't remember when it stopped, because I always just immediately overwrite our icons with my own custom ones.

Contributor

chdiza commented Oct 24, 2015

The icon-generating scripts are mainly for putting filetype-extension text on the document icons. There is no reason to do this on every build, which is why I'm glad it hasn't been happening on every build. I can't remember when it stopped, because I always just immediately overwrite our icons with my own custom ones.

@splhack

This comment has been minimized.

Show comment
Hide comment
@splhack

splhack Dec 13, 2015

Member

@chdiza you want to remove src/MacVim/icons/Makefile and icon generating code from this repository, because you just want to simplify the Macvim Homebrew formula to remove its custom-icon code? that's all?

Member

splhack commented Dec 13, 2015

@chdiza you want to remove src/MacVim/icons/Makefile and icon generating code from this repository, because you just want to simplify the Macvim Homebrew formula to remove its custom-icon code? that's all?

@splhack

This comment has been minimized.

Show comment
Hide comment
@splhack

splhack Dec 17, 2015

Member

move to #176

Member

splhack commented Dec 17, 2015

move to #176

@splhack splhack closed this Dec 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment