ci: Fix test artifact upload not working #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test_artifacts action (which we use to upload artifacts when a test has failed) relies on parsing the CI matrix values to generate a unique artifact name. However, in macvim-dev#1559 we switched to using a reusable workflow instead, which no longer uses a matrix inside the composable workflow. We could simply make a matrix with only one item in it to satisfy the test_artifact action but that seems a bit overkill. Instead, just modify it so we manually pass in the preferred artifact name instead which also gives us more flexibility in the naming. It does mean future upstream merges may cause conflicts.
ychin
added
Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_artifacts action (which we use to upload artifacts when a test has failed) relies on parsing the CI matrix values to generate a unique artifact name. However, in #1559 we switched to using a reusable workflow instead, which no longer uses a matrix inside the composable workflow. We could simply make a matrix with only one item in it to satisfy the test_artifact action but that seems a bit overkill. Instead, just modify it so we manually pass in the preferred artifact name instead which also gives us more flexibility in the naming. It does mean future upstream merges may cause conflicts.