Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix for script insertion on pages with comments #14

Merged
merged 1 commit into from

2 participants

Steve Rice Madalin Oprea
Steve Rice

On pages where the <head> element is not the first page element (such as pages following Paul Irish's conditional html class pattern) the toolbar.js script insertion will fail. This fix targets the <head> tag directly.

Madalin Oprea madalinoprea merged commit ef5d62b into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 9, 2012
  1. Attach script to head node whether or not it is the first element in …

    Steve Rice authored
    …the document
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  skin/js/toolbar.js
2  skin/js/toolbar.js 100644 → 100755
View
@@ -11,7 +11,7 @@
j(script).remove();
}
};
- document.documentElement.childNodes[0].appendChild(script)
+ document.getElementsByTagName('head')[0].appendChild(script)
}
})(window, document, "1.3", function($, jquery_loaded) {
Something went wrong with that request. Please try again.