Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
team description visibly corrupts write-up with "<" and ">" characters upon re-edit #778
Unfortunately caused by the fix for #700 ... same repro steps, but now attempting to write "less than 50% hp" as
This continues indefinitely -- eg,
(For what it's worth, this doesn't really seem like an "arbitrary HTML into team descriptions" issue -- these are symbols used in general English. Well,
Seems like the description might just need to be unescaped upon entering edit mode? Or perhaps disallow using those characters entirely (eg popup on save or some such) -- the feature is hardly vital, but text corruption seems a lot more frustrating than text restrictions (which can be worked around if known).
Confirmed, many thanks!! I can now mention "I&I" in my description, edit and save and re-edit without corruption.
(Note for posterity -- this may require minor user cleanup, possibly tied to any such special characters that were used between the fix for #700 and the fix for this ticket. That is, for my OLD descriptions that include
Ooof. :-/ Done stuff like that before myself.
One option is to make it clear that the sign needs to be audited now -- like replace
For descriptions which used it as a "A then B" indicator, there's no real harm -- eg "pop Urd <> Shiva = OKHO" is odd but fine. But for descriptions which use
Sure, there'll be some splash damage -- presumably such an approach would also affect