New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate two arg open #4

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@kaoru

kaoru commented Feb 23, 2015

Replaced a few 2-arg opens with 3-arg opens.

Maybe this can't be merged because of Perl 5.6 support?

For similar reasons I was going to replace all global bareword filehandles with lexical scalar filehandles but I thought that might also be a nod to Perl 5.6? But then there already is one lexical filehandle in in syslog.t line 307 so... not sure?

@maddingue

This comment has been minimized.

Owner

maddingue commented May 16, 2016

Actually, 3-args open() is available in 5.6. However, it isn't in 5.5, which Sys::Syslog still is compatible with.

Thanks for your proposition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment