Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Perl Critic on eg/syslog.pl #5
If you're going to give an example, might as well make it exemplar :-)
If I was going all out I would have used Getopt::Long and Pod::Usage to make a real script out of it, but I decided to just address the basic Perl::Critic complaints about it.
Syslog.pm contains a lot of Perl::Critic violations too, but I'm too afraid to change anything lest the Perl 5.6 support be broken. I tried installing Perl 5.6 using perlbrew but compilation failed. Shame.
Thanks for your contribution, but I quite disagree. eg/syslog.pl is just an example script, not a generic logging program like logger(1). It's merely the synopsis code put in a file, with very minimal arguments parsing so someone can poke at using
Regarding each of your patches: