From 5443071d50cd54b3b9f9b693d2dce8983ff4a355 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Diane=20Delall=C3=A9e?= Date: Thu, 27 May 2021 16:26:39 +0200 Subject: [PATCH 1/4] Proposition: the dig did not work on my machine MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The dig solution did not work on my machine, but I am not sure why (quite new with ruby and rails). the solution with brackets wroks, so maybe we can change that, But any explanation is really welcomed 😄 --- rails6/fr/chapter09-optimization.adoc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/rails6/fr/chapter09-optimization.adoc b/rails6/fr/chapter09-optimization.adoc index 9554bcd..b1ced17 100644 --- a/rails6/fr/chapter09-optimization.adoc +++ b/rails6/fr/chapter09-optimization.adoc @@ -203,10 +203,10 @@ class Api::V1::OrdersControllerTest < ActionDispatch::IntegrationTest json_response = JSON.parse(response.body) assert_equal @order.user.orders.count, json_response['data'].count - assert_not_nil json_response.dig(:links, :first) - assert_not_nil json_response.dig(:links, :last) - assert_not_nil json_response.dig(:links, :prev) - assert_not_nil json_response.dig(:links, :next) + assert_not_nil json_response['links']['first'] + assert_not_nil json_response['links']['last'] + assert_not_nil json_response['links']['prev'] + assert_not_nil json_response['links']['next'] end # ... end From e01ba693fdc15166cdafc78df0fd7561c4504f04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Diane=20Delall=C3=A9e?= Date: Fri, 28 May 2021 09:40:19 +0200 Subject: [PATCH 2/4] Use symbolize_names instead of changing to dic Co-authored-by: Alexandre Rousseau --- rails6/fr/chapter09-optimization.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rails6/fr/chapter09-optimization.adoc b/rails6/fr/chapter09-optimization.adoc index b1ced17..b3432b8 100644 --- a/rails6/fr/chapter09-optimization.adoc +++ b/rails6/fr/chapter09-optimization.adoc @@ -201,7 +201,7 @@ class Api::V1::OrdersControllerTest < ActionDispatch::IntegrationTest get api_v1_orders_url, headers: { Authorization: JsonWebToken.encode(user_id: @order.user_id) }, as: :json assert_response :success - json_response = JSON.parse(response.body) + json_response = JSON.parse(response.body, symbolize_names: true) assert_equal @order.user.orders.count, json_response['data'].count assert_not_nil json_response['links']['first'] assert_not_nil json_response['links']['last'] From a95672d048508ca6f335eab61f984da5e74c1d7e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Diane=20Delall=C3=A9e?= Date: Fri, 28 May 2021 09:56:19 +0200 Subject: [PATCH 3/4] reuse dig instead of dict --- rails6/fr/chapter09-optimization.adoc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/rails6/fr/chapter09-optimization.adoc b/rails6/fr/chapter09-optimization.adoc index b3432b8..7b7000c 100644 --- a/rails6/fr/chapter09-optimization.adoc +++ b/rails6/fr/chapter09-optimization.adoc @@ -203,10 +203,10 @@ class Api::V1::OrdersControllerTest < ActionDispatch::IntegrationTest json_response = JSON.parse(response.body, symbolize_names: true) assert_equal @order.user.orders.count, json_response['data'].count - assert_not_nil json_response['links']['first'] - assert_not_nil json_response['links']['last'] - assert_not_nil json_response['links']['prev'] - assert_not_nil json_response['links']['next'] + assert_not_nil json_response.dig(:links, :first) + assert_not_nil json_response.dig(:links, :last) + assert_not_nil json_response.dig(:links, :prev) + assert_not_nil json_response.dig(:links, :next) end # ... end From ac6b33a5fdaa8ae0004a853f9c5fee82ebb5a838 Mon Sep 17 00:00:00 2001 From: Alexandre Rousseau Date: Tue, 1 Jun 2021 15:44:29 +0200 Subject: [PATCH 4/4] Update chapter09-optimization.adoc --- rails6/fr/chapter09-optimization.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rails6/fr/chapter09-optimization.adoc b/rails6/fr/chapter09-optimization.adoc index 7b7000c..a5aa2c2 100644 --- a/rails6/fr/chapter09-optimization.adoc +++ b/rails6/fr/chapter09-optimization.adoc @@ -202,7 +202,7 @@ class Api::V1::OrdersControllerTest < ActionDispatch::IntegrationTest assert_response :success json_response = JSON.parse(response.body, symbolize_names: true) - assert_equal @order.user.orders.count, json_response['data'].count + assert_equal @order.user.orders.count, json_response[:data].count assert_not_nil json_response.dig(:links, :first) assert_not_nil json_response.dig(:links, :last) assert_not_nil json_response.dig(:links, :prev)