Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on Microsoft.Data.SqlClient 5.2.0 may be unnecessary #210

Closed
gliljas opened this issue May 27, 2024 · 5 comments
Closed

Dependency on Microsoft.Data.SqlClient 5.2.0 may be unnecessary #210

gliljas opened this issue May 27, 2024 · 5 comments
Labels
dependencies Pull requests that update a dependency file sql-server
Milestone

Comments

@gliljas
Copy link

gliljas commented May 27, 2024

Wasn't sure whether to file this issue at all, but at least for your consideration.

I had to do a version rollback today, since Microsoft.Data.SqlClient 5.2.0 is buggy and has a pending hotfix. DistributedLock.SqlServer doesn't really need that version, so the Nuget dependency becomes a bit limiting.

@madelson
Copy link
Owner

Is there a lower version you’d suggest instead? I’m happy to downgrade but I like to stay relatively recent

@madelson madelson added dependencies Pull requests that update a dependency file sql-server labels May 28, 2024
@madelson
Copy link
Owner

@gliljas looks like 5.2.1 is out. Does that work for you?

@madelson madelson added this to the 2.5 milestone Jun 30, 2024
madelson added a commit that referenced this issue Jun 30, 2024
@madelson
Copy link
Owner

@gliljas for now I published a new version with 5.2.1; if that's still causing problems for you please create a new issue

@mapaille
Copy link

@madelson I believe what @gliljas meant was to reference a more stable version, which is 5.1.5, the minimum version supported since EFCore 8.0.3. https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.SqlServer/8.0.7#dependencies-body-tab

@madelson
Copy link
Owner

@mapaille is 5.2.* is still causing issues, I'd happily accept a PR to downgrade to 5.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file sql-server
Projects
None yet
Development

No branches or pull requests

3 participants