Request For Comments
Made Tech team use this repository as a forum to discuss and make decisions. The outcomes of these discussions can be either an Action Plan, or a new Standard that Made Tech should follow.
- Create a new branch on this repo and copy
- Include any images etc in a separate directory named
rfc-000and link to them.
- Make a Pull Request (PR) for your branch.
- Rename your file and directory with the number of the PR and push as a new commits.
- Post a link to your PR in #announcements on Slack. Get it added to the weekly TGIF. Announce it at QT on Monday/Wednesday/Friday. @mention people in the PR description if you want particular attention from them.
- Made Tech team with then discuss your proposal using both inline comments against your RFC document and the general PR comments section.
- As changes are requested and agreed in comments, make the changes in your RFC and push them as new commits.
- Stay active in the discussion and encourage and remind other relevant people to participate. If you start an RFC it’s up to you to push it through the process and engage people.
- Once consensus is reached and approvals given using the GitHub review system, the PR can be merged.
- When an RFC is accepted, ensure the team are made aware of it via Slack, TGIF, or a PSA.
- An RFC can be rejected. This can happen if a consensus isn’t reached, or people agree rejecting it is the right thing to do. In this case the PR should be closed with a suitable comment.
Standards RFCs shouldn’t be substantially altered after they are accepted, although it’s fine to correct typos and other mistakes via a new PR. In order to change a Standard, the original RFC must be superseded by a new one. The process for this is:
- Create a new RFC PR as above, noting in the summary which RFC it is superseding.
- In the same branch, mark the old RFC as superseded and link to the new RFC and move (using
git mv) it into the archived directory.
- When the new RFC is accepted and the PR is merged, the old RFC will no longer be active.
Managing Action Plans
For RFCs where the outcome is an agreed Action Plan, you may want to update the RFC with meaningful status updates in new PRs. Once the plan is either complete or no longer relevant, it should be moved to the archived directory in a new PR.
Raising a concern with an RFC
There is no definitive process for discussing an RFC before the above process has been started, or after it has finished. To faciliate this, an [Issue][Issues] may be created to discuss potential changes. This provides a central place to discuss RFCs without the need of creating a new RFC.
Inspiration for this repository, and the process it sets out was 100% drawn from GOV.uk RFCs