New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $this->app->share reference, Add Service Provider to Repo, Update readme #8

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@MitchellMcKenna

MitchellMcKenna commented Mar 11, 2017

  • $this->app->share has been deprecated in laravel 5.4. This removes install instructions using this from readme and adds a service provider so user's don't have to create their own.
Add Service Provider to Repo, Update readme
- $this->app->share has been deprecated in laravel 5.4. This removes
  install instructions using this from readme and adds a service
  provider so user's don't have to create their own.
@GrahamCampbell

This comment has been minimized.

Show comment
Hide comment
@GrahamCampbell

GrahamCampbell Jun 18, 2017

Contributor

👎 for adding a service provider.

Contributor

GrahamCampbell commented Jun 18, 2017

👎 for adding a service provider.

@MitchellMcKenna

This comment has been minimized.

Show comment
Hide comment
@MitchellMcKenna

MitchellMcKenna Jun 19, 2017

@hannesvdvreken @GrahamCampbell Why is that? Having a default service provider allows the average user to get up and running easier. If you need more in your service provider you are still free to create your own. Having a default service provider will also need to be added if the package wishes to enable Laravel 5.5's upcoming package auto discovery.

MitchellMcKenna commented Jun 19, 2017

@hannesvdvreken @GrahamCampbell Why is that? Having a default service provider allows the average user to get up and running easier. If you need more in your service provider you are still free to create your own. Having a default service provider will also need to be added if the package wishes to enable Laravel 5.5's upcoming package auto discovery.

@GrahamCampbell

This comment has been minimized.

Show comment
Hide comment
@GrahamCampbell

GrahamCampbell Jun 19, 2017

Contributor

I don't think this class should actually be registered to the container, for most use cases.

Contributor

GrahamCampbell commented Jun 19, 2017

I don't think this class should actually be registered to the container, for most use cases.

@MitchellMcKenna

This comment has been minimized.

Show comment
Hide comment
@MitchellMcKenna

MitchellMcKenna Jun 19, 2017

It's the same class used in the example Service Provider in the readme, if most use cases use it differently we should update the readme example to that way.

MitchellMcKenna commented Jun 19, 2017

It's the same class used in the example Service Provider in the readme, if most use cases use it differently we should update the readme example to that way.

@GrahamCampbell

This comment has been minimized.

Show comment
Hide comment
@GrahamCampbell

GrahamCampbell Jun 19, 2017

Contributor

I think this sort of use case is surely much more common: https://github.com/GrahamCampbell/Laravel-GitHub/blob/v5.1.0/src/GitHubFactory.php#L86.

Contributor

GrahamCampbell commented Jun 19, 2017

I think this sort of use case is surely much more common: https://github.com/GrahamCampbell/Laravel-GitHub/blob/v5.1.0/src/GitHubFactory.php#L86.

@GrahamCampbell

This comment has been minimized.

Show comment
Hide comment
@GrahamCampbell

GrahamCampbell Jun 19, 2017

Contributor

That sort of use case requires no documentation IMO. It's just write your own code.

Contributor

GrahamCampbell commented Jun 19, 2017

That sort of use case requires no documentation IMO. It's just write your own code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment