Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove $this->app->share reference, Add Service Provider to Repo, Update readme #8
@hannesvdvreken @GrahamCampbell Why is that? Having a default service provider allows the average user to get up and running easier. If you need more in your service provider you are still free to create your own. Having a default service provider will also need to be added if the package wishes to enable Laravel 5.5's upcoming package auto discovery.
I think this sort of use case is surely much more common: https://github.com/GrahamCampbell/Laravel-GitHub/blob/v5.1.0/src/GitHubFactory.php#L86.