-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect build flag (-DPIC) in Makefile.in #684
Comments
drhsqlite
pushed a commit
to drhsqlite/fossil-mirror
that referenced
this issue
Jul 28, 2022
…m ticket for that change at [madler/zlib#684]. FossilOrigin-Name: 368d97869b516c1aa20672e0652b8394cc8fde70be9e889f2785c7f8a8db7f88
Incorporated. Thanks. |
drhsqlite
pushed a commit
to drhsqlite/fossil-mirror
that referenced
this issue
Nov 20, 2022
…b. Now there's only two (manual) cherry-picks required for zlib updates: [0f8bae079e] and [368d97869b] (though the upstream ticket for [368d97869b] is commented as "Incorporated" and closed: [madler/zlib#684]). FossilOrigin-Name: 1a52d387c219fd9898340c6bdfa9979718dfbe48d4fef82e427eb0bf68e60f4d
drhsqlite
pushed a commit
to drhsqlite/fossil-mirror
that referenced
this issue
Aug 20, 2023
…et for [368d97869b] is commented as "Incorporated" and closed, see [madler/zlib#684], but doesn't seem to have landed in the zlib release package.) FossilOrigin-Name: d8f4247b13dfab8b1f5dd2fb97c48a914080a2ad731e382798fcc5e86a5f5fbc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The 1.2.12 build fails to link on Linux x64 (specifically, Mint 20.3 with clang 10) because the build uses -DPIC instead of -fPIC. Insofar as i grep can see, there is no macro named "PIC" used by the source files, so this appears to be a typo in Makefile.in. Globally replacing -DPIC with -fPIC fixes the build.
The text was updated successfully, but these errors were encountered: