Prototype version #48

Closed
victor-homyakov opened this Issue May 5, 2011 · 2 comments

Comments

Projects
None yet
3 participants
Contributor

victor-homyakov commented May 5, 2011

I receive such message from DOM Monster 1.3.1:
You are using the Prototype JavaScript framework v1.7. There's a newer version available, which potentially includes performance updates.

Is this a bug or not?

Contributor

victor-homyakov commented May 6, 2011

Results from Chrome console:

> JR.versionCompare("1.7", [1, 7])
true
> JR.versionCompare("1.7.1", [1, 7, 1])
true
> JR.versionCompare("1.7", [1, 7, 1])
true
> JR.versionCompare("1.6", [1, 7])
false
> JR.versionCompare("1.6.0.3", [1, 7])
false

Either invert result of JR.versionCompare (true instead of false) or use if('Prototype' in window && !JR.versionCompare(.... Also JR.versionCompare("1.7", [1, 7, 1]) should return false.

mRs- commented Dec 12, 2011

seems like you figured this already out. Make a Fork and a Pull Request please

@victor-homyakov victor-homyakov added a commit to victor-homyakov/dom-monster that referenced this issue Dec 13, 2011

@victor-homyakov victor-homyakov Fix for issue #48 e2b5cc6

@madrobby madrobby added a commit that referenced this issue Dec 13, 2011

@madrobby madrobby Merge pull request #55 from victor-homyakov/master
Fix of issue #48
35dc5b6

madrobby closed this Dec 13, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment