Skip to content

Prevent from calling callbacks from different scopes for the same shortcut #48

okonet opened this Issue Aug 13, 2012 · 1 comment

2 participants

okonet commented Aug 13, 2012
  1. Assign same shortcut for 2 different scopes "a" and "b"
  2. Change scope to "b" in the first's shortcut callback

Result: both callbacks gets called

okonet commented Aug 13, 2012

Related to #28

@madrobby madrobby pushed a commit that closed this issue Aug 13, 2012
@okonet okonet Defer setting of scope in setScope to prevent potential loop or calli…
…ng callbacks from different scope for the same shortcut. Fixes #28. Fixes #48
@madrobby madrobby closed this in 5782b14 Aug 13, 2012
@okonet okonet added a commit to okonet/keymaster that referenced this issue Aug 14, 2012
@okonet okonet Removed setTimeout from setScope since it's unreliable and breaks tes…
…ts. Instead passing _scope to a callback as argument to ensure it remains the same by the time of execution. Fixes #48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.