Skip to content

key.unbind tries to test obj.scope even when obj is undefined #111

Closed
wants to merge 1 commit into from

2 participants

@garth
garth commented Jan 6, 2014

No description provided.

@urbany
urbany commented Feb 19, 2014

I was just hit by this error also.
IMHO the real problem here is the for loop not checking if a in a property of b. Something like this should be used:

for (i in _handlers[key]) {
  if (!_handlers[key].hasOwnProperty(i)) {
    continue;
  }
  // ...
}
@urbany urbany added a commit that referenced this pull request Feb 19, 2014
@urbany urbany Proper unbinding of keys.
key.unbind tries to test obj.scope even when obj is undefined, other way to fix: #111
54f81ce
@urbany urbany referenced this pull request Feb 19, 2014
Closed

Proper unbinding of keys. #116

@madrobby madrobby closed this in 5004b91 Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.