key.unbind tries to test obj.scope even when obj is undefined #111

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@garth

garth commented Jan 6, 2014

No description provided.

@urbany

This comment has been minimized.

Show comment
Hide comment
@urbany

urbany Feb 19, 2014

I was just hit by this error also.
IMHO the real problem here is the for loop not checking if a in a property of b. Something like this should be used:

for (i in _handlers[key]) {
  if (!_handlers[key].hasOwnProperty(i)) {
    continue;
  }
  // ...
}

urbany commented Feb 19, 2014

I was just hit by this error also.
IMHO the real problem here is the for loop not checking if a in a property of b. Something like this should be used:

for (i in _handlers[key]) {
  if (!_handlers[key].hasOwnProperty(i)) {
    continue;
  }
  // ...
}

@urbany urbany referenced this pull request Feb 19, 2014

Closed

Proper unbinding of keys. #116

@madrobby madrobby closed this in 5004b91 Mar 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment