Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Proper unbinding of keys. #116

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

urbany commented Feb 19, 2014

key.unbind tries to test obj.scope even when obj is undefined, other way to fix: #111

Proper unbinding of keys.
key.unbind tries to test obj.scope even when obj is undefined, other way to fix: #111
Owner

madrobby commented Feb 19, 2014

I've no idea what this fixes. Can you add a test demonstrating what doesn't work?

urbany commented Feb 19, 2014

Hey madrobby to do it now, but i can add a test later. The gist of it is this:
In my project I use Ember - emberjs.com - and ember adds some functions to the prototype of arrays, like _super. Your for in loop is looping through these prototype keys also when it should be looping only through it's own defined properties. More info about it: http://stackoverflow.com/a/86306/506979

Also thanks for the quick reply!

@madrobby madrobby closed this Mar 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment