Modifiers reset issue #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I encountered the same issue and this patch is apparently fixing it. I'm wondering why this pull request hasn't been accepted yet. Thanks for working on this @clvrobj. |
|
Agreed, I ended up moving off of Keymaster and onto Mousetrap because of this great library not getting any maintenance nowadays. |
|
Unfortunately, Mousetrap doesn't provide scopes (yet). And between creating a plugin to add support for scopes to Mousetrap and just applying @clvrobj's patch in a fork of keymaster, I chose the latter. Later I might migrate, but I'm OK for the moment. Ah, it's just been merged. Cool, no need to maintain a fork! |
|
@igstan it's good to bump stuff from time to time to remind me! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the modifier keys are reset when page get focus, then if you keep one of the modifier key down, but unfortunately it is ignored. (refer to #36)
This change is using the event.[ctrlKey, altKey, shiftKey, metaKey] to check the modifiers key and can pass the tests.
But don't know if any side effect here, please help to check, thanks.