Resolves an issue with drop targets being incorrectly offset in a scrolled scroll container #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has been scrolled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #32. When dragging draggables within a scroll container, the droppable does not register the scrollLeft or scrollTop of the scrolling container, resulting in a drop offset that is incorrect. This is particularly noticeable in Sortables when trying to drag down or to the right beyond the scroll limits.
There's still some weird stuff going on when dragging beyond the boundaries of the scroll container, the mouse position relative to the draggable gets altered so that the draggable is no longer below the cursor, but at least the item actually drops into the right place now. Hopefully someone more competent than I can figure out that bug.