Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Cannot pass button options to dialog buttons #23

Open
colinmollenhour opened this Issue · 2 comments

2 participants

@colinmollenhour

Simple solution:
if a button "options" property exists then pass it to the UI.Button constructor. Resulting example for API would be something like:

new S2.UI.Dialog({
   ...,
   buttons:[ {
      primary:true,
      label:'OK',
      action:someAction,
      options:{icons:{primary:'ui-icon-check'}}
   } ]
}
@colinmollenhour

No:
https://github.com/madrobby/scripty2/blob/master/src/ui/controls/dialog.js#L192
I'm essentially talking about changing that line to:
new UI.Button(element,button.options || {});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.