serializeData function does not use options.traditional from ajax settings #676

Closed
ryanbeard opened this Issue Jan 11, 2013 · 5 comments

Comments

Projects
None yet
3 participants
@ryanbeard

When making an ajax request, if you set the traditional option to true, this is not then applied to serializing the parameters.

@ryanbeard

This comment has been minimized.

Show comment
Hide comment
@ryanbeard

ryanbeard Jan 11, 2013

Should just be a case of adding options.traditional as an additional parameter to the $.param function call...

Should just be a case of adding options.traditional as an additional parameter to the $.param function call...

@mislav

This comment has been minimized.

Show comment
Hide comment
@mislav

mislav Jan 11, 2013

Collaborator

Yeah, I also think it won't be a huge change. Can you try making

Collaborator

mislav commented Jan 11, 2013

Yeah, I also think it won't be a huge change. Can you try making

@mislav

This comment has been minimized.

Show comment
Hide comment
@mislav

mislav Jan 13, 2013

Collaborator

Can you try making a pull-request? With corresponding test of course

Collaborator

mislav commented Jan 13, 2013

Can you try making a pull-request? With corresponding test of course

@ryanbeard

This comment has been minimized.

Show comment
Hide comment
@ryanbeard

ryanbeard Jan 13, 2013

Hi Mislav. I can't do anything for a few days due to other commitments, but will test and implement the change when I get a chance. Thanks, Ryan

-----Original Message-----

From: Mislav Marohnić
Sent: 13 Jan 2013 15:05:57 GMT
To: madrobby/zepto
Cc: ryanbeard
Subject: Re: [zepto] serializeData function does not use options.traditional from ajax settings (#676)

Can you try making a pull-request? With corresponding test of course


Reply to this email directly or view it on GitHub:
#676 (comment)

Hi Mislav. I can't do anything for a few days due to other commitments, but will test and implement the change when I get a chance. Thanks, Ryan

-----Original Message-----

From: Mislav Marohnić
Sent: 13 Jan 2013 15:05:57 GMT
To: madrobby/zepto
Cc: ryanbeard
Subject: Re: [zepto] serializeData function does not use options.traditional from ajax settings (#676)

Can you try making a pull-request? With corresponding test of course


Reply to this email directly or view it on GitHub:
#676 (comment)

@madrobby

This comment has been minimized.

Show comment
Hide comment
@madrobby

madrobby Nov 24, 2013

Owner

Bump. Any takers to fix this issue?

Owner

madrobby commented Nov 24, 2013

Bump. Any takers to fix this issue?

@mislav mislav closed this in cb20224 Dec 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment