Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing transitionEnd-Event Bubble-Error Issue #305 #444

Merged
merged 2 commits into from Mar 20, 2012

Conversation

@ccoenen
Copy link
Contributor

commented Mar 19, 2012

I fixed #305 by checking for the identity of event.target and event.currentTarget.
This made the switch from .one to .bind neccessary, as the event could occur multiple times. It is then unbound manually.

@renaudleo

This comment has been minimized.

Copy link

commented on a1daca6 Mar 19, 2012

I think this syntax would better fit zepto's general code styling :

  if (event.target !== event.currentTarget) return;
@madrobby

This comment has been minimized.

Copy link
Owner

commented Mar 20, 2012

Look good, but needs a test (in test/fx.html)

@ccoenen

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2012

Thanks for the heads-up. Of course i messed up a case we never used internally (0-duration anim) :-D

This is now fixed. I also took renaudleo's advice on code-style.

madrobby added a commit that referenced this pull request Mar 20, 2012

Merge pull request #444 from meso-unimpressed/anim-bubble-issue305
Fixing transitionEnd-Event Bubble-Error Issue #305

@madrobby madrobby merged commit 43dccd7 into madrobby:master Mar 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.