Enable isPropagationStopped; fix order of evalating <script> #550

Closed
wants to merge 2 commits into from

3 participants

@2y
2y commented Jul 17, 2012

pull request for zepto to act like jquery

Yuta Yamashita added some commits Jul 17, 2012
Yuta Yamashita Change the order of evaluating the script content
In jQuery, all the nodes appeared before a script tag are inserted when
the script content is evaluated, but in zepto, all nodes before the
script is inserted *after* the script is evaluated.
Changed it to behave the same with jQuery.
a107ace
Yuta Yamashita bug fix for enabling "isPropagationStopped" d0a00a9
@madrobby
Owner

Thanks for the patch. We need to have proper unit tests before this can go in.

@mislav mislav added a commit that closed this pull request Oct 1, 2012
@mislav mislav rewrite after/prepend/before/append() to fix eval
In some of these operations <script> tags would be eval'ed in the wrong
order. The rewrite ensures a consistent eval order and improves code
readability.

Closes #550
17f69f4
@mislav mislav closed this in 17f69f4 Oct 1, 2012
@lopper lopper added a commit to buddydvd/zepto that referenced this pull request Apr 24, 2013
@mislav mislav rewrite after/prepend/before/append() to fix eval
In some of these operations <script> tags would be eval'ed in the wrong
order. The rewrite ensures a consistent eval order and improves code
readability.

Closes #550
4caab90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment