Touch events don't return any position data. #564

Closed
wants to merge 3 commits into from

5 participants

@sdeboer

This patch suggests a method by which the touch events could return the position of the initial touch and release for a touch event.

Currently the event that is passed to the client code does not include any positional data and sometimes it is significant to know where in the object the touch occurred.

@travisbot

This pull request fails (merged ba4ad9e into 73206a6).

@sdeboer

I'm sorry, I have no idea what this Travis output is supposed to tell me...except that I failed.

It clearly shows a bunch of tests passing then with no clear errors says "rake aborted"

And I have no idea about TravisBot. If a human will even see this now...

@madrobby
Owner

You probably forgot to run rake whitespace. This will cause the tests to fail.

@travisbot

This pull request passes (merged 19c35cf into 73206a6).

@sdeboer

Oh, okay. Thanks!

Travis liked that.

@thegrubbsian

Any way we could get this merged in soon? I could really use this.

@mislav
Collaborator

@thegrubbsian You can use it right now. Simply check out "master" branch from @sdeboer's repo; build Zepto from there.

Even after we merge it, you would still need to check out our master branch and build Zepto from there. So, the amount of work you need to do is the same. You don't have to wait for us.

@thegrubbsian

Yeah, thats what I've been doing, but I have an app for a client that they're going to maintain and I'd prefer the dependencies be from the source repo. No big deal, just wondering if it was gonna make it in eventually. Thanks for the quick reply.

@madrobby madrobby referenced this pull request Nov 24, 2013
Closed

Event parameter object #601

@madrobby
Owner

We should probably just return the touch event itself as event data.

@madrobby madrobby was assigned Nov 24, 2013
@madrobby
Owner

Closing this because we don’t want to add extra features to the touch or gesture modules. Feel free to fork them and provide them as your own zepto plugin with the extra functionality you need.

@madrobby madrobby closed this Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment