Multi-windows support for embedded scripts #671

Merged
merged 1 commit into from Jul 12, 2016

Conversation

Projects
None yet
3 participants
Contributor

asual commented Jan 3, 2013

This should fix an issue with embedded scripts that are injected in a dynamically created IFRAME. If this operation is performed in the top window then the script is always evaluated there.

Multi-windows support for embedded scripts
This should fix an issue with embedded scripts that are injected in a dynamically created IFRAME. If this operation is performed in the top window then the script is always evaluated there.
Collaborator

mislav commented Jan 3, 2013

To clarify: this change makes it so that if some HTML is injected in one of the sub-windows, SCRIPT tags get eval'ed in the respective window?

Contributor

asual commented Jan 3, 2013

Yes! My case includes dynamically created IFRAMEs in which I load HTML snippets containing SCRIPT tags. It's great that the code is automatically executed but it breaks when I have require.js calls that inject their dependencies in the top window.

Owner

madrobby commented Sep 13, 2013

Needs tests before we can merge this. Is this also the same way jQuery works?

@ghost ghost assigned mislav Sep 13, 2013

@mislav mislav merged commit 30ea753 into madrobby:master Jul 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment