New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prop name fix like jQuery #756

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
@edokeh
Contributor

edokeh commented May 16, 2013

This code $('#text').prop('readonly', true) doesn't work with zepto but work with jQuery.
Because jQuery did some property name fix works, see https://github.com/jquery/jquery/blob/1.9.1/src/attributes.js#L393

@vulgarcoder

This comment has been minimized.

Show comment
Hide comment
@vulgarcoder

vulgarcoder commented Oct 12, 2013

👍

@madrobby

This comment has been minimized.

Show comment
Hide comment
@madrobby

madrobby Oct 16, 2013

Owner

This does seem useful, though it does add a bunch of extra code. I'm leaning to add it, but it does need tests for all the attribute names affected, with real corresponding DOM elements.

Owner

madrobby commented Oct 16, 2013

This does seem useful, though it does add a bunch of extra code. I'm leaning to add it, but it does need tests for all the attribute names affected, with real corresponding DOM elements.

@madrobby

This comment has been minimized.

Show comment
Hide comment
@madrobby

madrobby Nov 19, 2013

Owner

Bump—anyone up for writing tests?

Owner

madrobby commented Nov 19, 2013

Bump—anyone up for writing tests?

@edokeh

This comment has been minimized.

Show comment
Hide comment
@edokeh

edokeh Nov 20, 2013

Contributor

So busy these months, sorry
I have added the test for this feature.

Contributor

edokeh commented Nov 20, 2013

So busy these months, sorry
I have added the test for this feature.

@ghost ghost assigned mislav Nov 24, 2013

@mislav

This comment has been minimized.

Show comment
Hide comment
@mislav

mislav Nov 25, 2013

Collaborator

Thanks! I merged this.

Collaborator

mislav commented Nov 25, 2013

Thanks! I merged this.

@mislav mislav closed this Nov 25, 2013

@rollo-zhou

This comment has been minimized.

Show comment
Hide comment
@rollo-zhou

rollo-zhou commented Feb 18, 2014

@dreambt

This comment has been minimized.

Show comment
Hide comment
@dreambt

dreambt commented Feb 26, 2014

So cool!

@Credochen

This comment has been minimized.

Show comment
Hide comment
@Credochen

Credochen commented Mar 28, 2014

+1

@cisolarix

This comment has been minimized.

Show comment
Hide comment
@cisolarix

cisolarix commented Apr 3, 2014

+1

@evanoxu

This comment has been minimized.

Show comment
Hide comment
@evanoxu

evanoxu commented Apr 29, 2014

+1

@oikewll

This comment has been minimized.

Show comment
Hide comment
@oikewll

oikewll commented Jun 9, 2014

+1

@lightningtgc

This comment has been minimized.

Show comment
Hide comment
@lightningtgc

lightningtgc Jun 9, 2014

已经close那么久了,早就支持了,为什么还有那么多人跑来赞跟+1,能先看一下么。。。。。。。。

lightningtgc commented Jun 9, 2014

已经close那么久了,早就支持了,为什么还有那么多人跑来赞跟+1,能先看一下么。。。。。。。。

@wuwb

This comment has been minimized.

Show comment
Hide comment
@wuwb

wuwb commented Sep 4, 2014

cool!

@HuiguoRose

This comment has been minimized.

Show comment
Hide comment
@HuiguoRose

HuiguoRose commented Apr 13, 2015

+1

@programfuture

This comment has been minimized.

Show comment
Hide comment
@programfuture

programfuture commented Aug 4, 2015

+1

@Cleam

This comment has been minimized.

Show comment
Hide comment
@Cleam

Cleam commented Dec 5, 2015

+1

@zengqi

This comment has been minimized.

Show comment
Hide comment
@zengqi

zengqi commented Mar 25, 2016

+1

@a932455223

This comment has been minimized.

Show comment
Hide comment
@a932455223

a932455223 commented Apr 6, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment