Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/setuptools #71

Merged
merged 3 commits into from Nov 7, 2018
Merged

Fix/setuptools #71

merged 3 commits into from Nov 7, 2018

Conversation

@orsinium
Copy link
Contributor

@orsinium orsinium commented Oct 8, 2018

  1. Removed setuptools from requirements. Fix #58
  2. Fix flake8 warnings in setup.py
  3. Improve python version checks as recommend in setuptools documentation
@orsinium
Copy link
Contributor Author

@orsinium orsinium commented Nov 5, 2018

@madzak, could you, please, review this PR?

@madzak madzak merged commit a6a5005 into madzak:master Nov 7, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@madzak
Copy link
Owner

@madzak madzak commented Nov 7, 2018

Thanks for the commit, sorry for the delay in merge!

@orsinium
Copy link
Contributor Author

@orsinium orsinium commented Nov 7, 2018

It's OK, thank you. Have a good day :)

@orsinium orsinium deleted the orsinium-forks:fix/setuptools branch Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants