Help windows #110

Merged
merged 5 commits into from Nov 29, 2013

Conversation

Projects
None yet
2 participants
@MinchinWeb
Collaborator

MinchinWeb commented Nov 27, 2013

Fixed a couple of random typos and tried to make the program work nicer on Windows systems. Changes should only effect Windows installations. Specifically:

  • change prompt on exit code from mutliline entries
  • change default linewrap to 79 (from 80)
  • add MS Visual Studio (PyTools) files to .gitignore

P.S. Very cool piece of software :)

MinchinWeb added some commits Nov 27, 2013

your chance to make a programmer happy :)
fix small typo in CONTRIBUTING.md
Change break msg for Windows
for multiline input on Windows, you need Ctrl+Z to exit
Windows: wraps lines at 79 chars by default
trying to wrap lines at 80 char in Windows' CMD results in blank lines
following lines that are exactly 80 char long
@maebert

This comment has been minimized.

Show comment
Hide comment
@maebert

maebert Nov 27, 2013

Owner

Awesome, thank you so much! I think you're missing an import sys there, then tests will pass as well :)

Owner

maebert commented Nov 27, 2013

Awesome, thank you so much! I think you're missing an import sys there, then tests will pass as well :)

@maebert

This comment has been minimized.

Show comment
Hide comment
@maebert

maebert Nov 27, 2013

Owner

On second thought, in happy to change the default line wrap to 79 or 78 globally. Let's not make a special case for win there.

Owner

maebert commented Nov 27, 2013

On second thought, in happy to change the default line wrap to 79 or 78 globally. Let's not make a special case for win there.

@MinchinWeb

This comment has been minimized.

Show comment
Hide comment
@MinchinWeb

MinchinWeb Nov 29, 2013

Collaborator

I've updated the code to that lines wrap at 79 chars globally

Collaborator

MinchinWeb commented Nov 29, 2013

I've updated the code to that lines wrap at 79 chars globally

@maebert

This comment has been minimized.

Show comment
Hide comment
@maebert

maebert Nov 29, 2013

Owner

Fantastic, thanks for your effort!

Owner

maebert commented Nov 29, 2013

Fantastic, thanks for your effort!

maebert added a commit that referenced this pull request Nov 29, 2013

@maebert maebert merged commit 91b4257 into maebert:master Nov 29, 2013

1 check passed

default The Travis CI build passed
Details

@MinchinWeb MinchinWeb deleted the MinchinWeb:help-windows branch Nov 29, 2013

@MinchinWeb

This comment has been minimized.

Show comment
Hide comment
@MinchinWeb

MinchinWeb Nov 29, 2013

Collaborator

thanks for making it to easy to contribute!

Collaborator

MinchinWeb commented Nov 29, 2013

thanks for making it to easy to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment