From 82e1d21aa5febf102c6869ca10a7d5bb1ed4f0e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ma=C3=ABl=20Chiotti?=
 <44336112+maelchiotti@users.noreply.github.com>
Date: Fri, 29 May 2026 16:11:37 +0200
Subject: [PATCH] fix: labels providers updates

---
 lib/common/actions/notes/labels.dart              |  3 +++
 lib/pages/notes/notes_page.dart                   |  7 +++++++
 lib/providers/notes/notes_provider.dart           | 15 +++++++++++++++
 .../notifiers/current_note_notifier.dart          | 12 +++++-------
 lib/providers/notifiers/notifiers.dart            |  2 +-
 5 files changed, 31 insertions(+), 8 deletions(-)

diff --git a/lib/common/actions/notes/labels.dart b/lib/common/actions/notes/labels.dart
index 1e5520ad..0735c5d5 100644
--- a/lib/common/actions/notes/labels.dart
+++ b/lib/common/actions/notes/labels.dart
@@ -44,6 +44,9 @@ Future<List<Label>?> selectLabels(BuildContext context, WidgetRef ref, {required
       .editLabels(note, selectedLabels);
 
   currentNoteNotifier.value = note;
+  // Forcefully notify the listeners
+  // because the note object as been modified in memory
+  currentNoteNotifier.notify();
 
   return selectedLabels;
 }
diff --git a/lib/pages/notes/notes_page.dart b/lib/pages/notes/notes_page.dart
index 40581441..33bcc591 100644
--- a/lib/pages/notes/notes_page.dart
+++ b/lib/pages/notes/notes_page.dart
@@ -35,6 +35,13 @@ class NotesPage extends ConsumerStatefulWidget {
 }
 
 class _NotesPageState extends ConsumerState<NotesPage> {
+  @override
+  void initState() {
+    super.initState();
+
+    currentLabelFilter = widget.label;
+  }
+
   @override
   void dispose() {
     currentLabelFilter = null;
diff --git a/lib/providers/notes/notes_provider.dart b/lib/providers/notes/notes_provider.dart
index ddb87022..a390e761 100644
--- a/lib/providers/notes/notes_provider.dart
+++ b/lib/providers/notes/notes_provider.dart
@@ -82,6 +82,8 @@ class Notes extends _$Notes {
   Future<bool> editLabels(Note note, Iterable<Label> selectedLabels) async {
     _checkStatus([NoteStatus.available, NoteStatus.archived]);
 
+    final removedLabels = note.labels.toList().where((label) => !selectedLabels.contains(label));
+
     try {
       await _notesService.putLabels(note, selectedLabels);
     } catch (exception, stackTrace) {
@@ -104,6 +106,7 @@ class Notes extends _$Notes {
 
     state = AsyncData(notes.sorted());
     _updateUnlabeledProvider();
+    _updateLabeledProviders([...removedLabels, ...selectedLabels]);
 
     return true;
   }
@@ -126,6 +129,7 @@ class Notes extends _$Notes {
 
     state = AsyncData(notes.sorted());
     _updateUnlabeledProvider();
+    _updateLabeledProviders(selectedLabels);
 
     return true;
   }
@@ -333,6 +337,17 @@ class Notes extends _$Notes {
     }
   }
 
+  /// Updates the labeled notes providers except this one it is a provider filtered by a label.
+  void _updateLabeledProviders(Iterable<Label> labels) {
+    for (final label in labels) {
+      if (label == this.label) {
+        continue;
+      }
+
+      ref.read(notesProvider(status: status, label: label).notifier).get();
+    }
+  }
+
   /// Updates the notes provider with the [status].
   void _updateStatusProvider(NoteStatus status) {
     ref.read(notesProvider(status: status).notifier).get();
diff --git a/lib/providers/notifiers/current_note_notifier.dart b/lib/providers/notifiers/current_note_notifier.dart
index d68b0e65..94f2ac71 100644
--- a/lib/providers/notifiers/current_note_notifier.dart
+++ b/lib/providers/notifiers/current_note_notifier.dart
@@ -17,15 +17,13 @@ class CurrentNoteNotifier extends ValueNotifier<Note?> {
   /// Sets the current note to [newNote].
   @override
   set value(Note? newNote) {
-    if (newNote == null) {
-      return;
-    }
+    _value = newNote;
 
-    if (_value == newNote && _value?.labels == newNote.labels) {
-      return;
-    }
+    notifyListeners();
+  }
 
-    _value = newNote;
+  /// Notifies the listeners.
+  void notify() {
     notifyListeners();
   }
 }
diff --git a/lib/providers/notifiers/notifiers.dart b/lib/providers/notifiers/notifiers.dart
index 65587a8a..e90884eb 100644
--- a/lib/providers/notifiers/notifiers.dart
+++ b/lib/providers/notifiers/notifiers.dart
@@ -14,7 +14,7 @@ final lockAppNotifier = LockNotifier(PreferenceKey.lockApp.preferenceOrDefault);
 /// Notifier for whether the current note is locked.
 final lockNoteNotifier = LockNotifier(false);
 
-/// Notifier for the value of the current label filter on the notes.
+/// The value of the current label filter on the notes.
 Label? currentLabelFilter;
 
 /// Notifier for whether the notes selection mode is active.