New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import cordia h-d mouse patch (was: Package (and/or port) extmou) #50

Closed
MerlijnWajer opened this Issue Feb 1, 2018 · 11 comments

Comments

Projects
None yet
4 participants
@MerlijnWajer

This comment has been minimized.

Show comment
Hide comment
@MerlijnWajer

MerlijnWajer Feb 7, 2018

Member

This might not be required / a good idea; see http://talk.maemo.org/showthread.php?p=1540971#post1540971

Member

MerlijnWajer commented Feb 7, 2018

This might not be required / a good idea; see http://talk.maemo.org/showthread.php?p=1540971#post1540971

@MerlijnWajer

This comment has been minimized.

Show comment
Hide comment
Member

MerlijnWajer commented Feb 12, 2018

@MerlijnWajer MerlijnWajer changed the title from Package (and/or port) extmou to Import cordia h-d mouse patch (was: Package (and/or port) extmou) Feb 12, 2018

@parazyd

This comment has been minimized.

Show comment
Hide comment
@parazyd

parazyd Feb 12, 2018

Member

Patched and built. Should be in the Leste repos as of now.

Close when tested.

Member

parazyd commented Feb 12, 2018

Patched and built. Should be in the Leste repos as of now.

Close when tested.

@android-808

This comment has been minimized.

Show comment
Hide comment
@android-808

android-808 Feb 13, 2018

Virtualbox 5.2.2 defaults pointing device to USB Tablet, so cursor should remain hidden. Changing to PS/2 Mouse I would expect it to be shown but it remains hidden.

android-808 commented Feb 13, 2018

Virtualbox 5.2.2 defaults pointing device to USB Tablet, so cursor should remain hidden. Changing to PS/2 Mouse I would expect it to be shown but it remains hidden.

@freemangordon

This comment has been minimized.

Show comment
Hide comment
@freemangordon

freemangordon Feb 14, 2018

Please check if cursor theme contains non-tansparent cursor

freemangordon commented Feb 14, 2018

Please check if cursor theme contains non-tansparent cursor

@android-808

This comment has been minimized.

Show comment
Hide comment
@android-808

android-808 Feb 14, 2018

Oh yeah, forgot that. I have tried adding gtk-cursor-theme-name = "Adwaita" to ~/.gtkrc-2.0 and the gtkrc for the default theme (/usr/share/themes/default). Also tried backing up the original "transp" cursor and copying arrow from Adwaita over the top.

android-808 commented Feb 14, 2018

Oh yeah, forgot that. I have tried adding gtk-cursor-theme-name = "Adwaita" to ~/.gtkrc-2.0 and the gtkrc for the default theme (/usr/share/themes/default). Also tried backing up the original "transp" cursor and copying arrow from Adwaita over the top.

@MerlijnWajer

This comment has been minimized.

Show comment
Hide comment
@MerlijnWajer

MerlijnWajer Feb 16, 2018

Member

Any luck with this?

Member

MerlijnWajer commented Feb 16, 2018

Any luck with this?

@MerlijnWajer

This comment has been minimized.

Show comment
Hide comment
@MerlijnWajer

MerlijnWajer Apr 6, 2018

Member

I've confirmed that the patch works: it does call the right code set the cursor, but then still you can't see anything, likely because the cursor is transparent or missing.

This will show a cursor:

wget https://ptpb.pw/9rhd -O foo.xbm
xsetroot -cursor foo.xbm foo.xbm

Now we just need to figure out if we can't just always provide proper cursors and have h-d call show/hide cursor at the right moments.

Member

MerlijnWajer commented Apr 6, 2018

I've confirmed that the patch works: it does call the right code set the cursor, but then still you can't see anything, likely because the cursor is transparent or missing.

This will show a cursor:

wget https://ptpb.pw/9rhd -O foo.xbm
xsetroot -cursor foo.xbm foo.xbm

Now we just need to figure out if we can't just always provide proper cursors and have h-d call show/hide cursor at the right moments.

@MerlijnWajer

This comment has been minimized.

Show comment
Hide comment
@MerlijnWajer

MerlijnWajer Apr 6, 2018

Member

/usr/share/icons/default/cursors/left_ptr is empty and owned by osso-af-utils:

# dpkg -S /usr/share/icons/default/cursors/left_ptr
osso-af-utils: /usr/share/icons/default/cursors/left_ptr

We should probably remove the transparent cursor if we hide the cursor anyway?

Member

MerlijnWajer commented Apr 6, 2018

/usr/share/icons/default/cursors/left_ptr is empty and owned by osso-af-utils:

# dpkg -S /usr/share/icons/default/cursors/left_ptr
osso-af-utils: /usr/share/icons/default/cursors/left_ptr

We should probably remove the transparent cursor if we hide the cursor anyway?

@MerlijnWajer

This comment has been minimized.

Show comment
Hide comment
@MerlijnWajer

MerlijnWajer Apr 6, 2018

Member

OK, found the root cause, I think. Even when left_ptr as above is not empty, it still doesn't work. Our hildon-desktop uses the XFixes variant of the cursor-showing method. libmatchbox used to use that, but since 2009 they stopped using it, and instead just use XDefineCursor. In this case, we should use XUndefineCursor to restore the original cursor, since that will reload the default cursor if called on the root window, per XUndefineCursor man page.

Rebuilding hildon-desktop with HAVE_XFIXES undefined makes it works for me on a raspi3 with a mouse attached.

Member

MerlijnWajer commented Apr 6, 2018

OK, found the root cause, I think. Even when left_ptr as above is not empty, it still doesn't work. Our hildon-desktop uses the XFixes variant of the cursor-showing method. libmatchbox used to use that, but since 2009 they stopped using it, and instead just use XDefineCursor. In this case, we should use XUndefineCursor to restore the original cursor, since that will reload the default cursor if called on the root window, per XUndefineCursor man page.

Rebuilding hildon-desktop with HAVE_XFIXES undefined makes it works for me on a raspi3 with a mouse attached.

@MerlijnWajer

This comment has been minimized.

Show comment
Hide comment
@MerlijnWajer

MerlijnWajer Apr 6, 2018

Member

Should be fixed in hildon-desktop 2.2.157.8

Member

MerlijnWajer commented Apr 6, 2018

Should be fixed in hildon-desktop 2.2.157.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment